Open
Conversation
fb1688e to
1d515f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces ESLint with oxlint, pulling in the shared
@apify/oxlint-configpreset andoxlint-tsgolintfor type-aware rules. Mirrors the migration already shipped in apify-storage-local-js, apify-shared-js, apify-client-js, and apify-core. Biome stays as the formatter — no formatting changes.What changed
@apify/eslint-config,eslint,eslint-config-prettier,eslint-plugin-react,eslint-plugin-react-hooks,globals,typescript-eslintoxlint@1.62.0,oxlint-tsgolint@0.22.0,@apify/oxlint-config@^0.2.5@apify/tsconfigto^0.1.2(drops removedimportsNotUsedAsValuesoption thatoxlint-tsgolintflags as invalid)eslint.config.mjswithoxlint.config.ts; drop unusedtsconfig.eslint.jsonlint/lint:fix(andlint-staged) now runoxlint --type-awarereferences: [{ "path": ".." }]fromtest/tsconfig.json— the root tsconfig isn't acompositeproject, and tsgolint rejects the malformed reference. The reference wasn't doing anything for tsc either.String#startsWith(utils.ts).Things to note
website/(one.jsxfile) is ignored, matching biome's behaviour. Not worth carrying React linting just for that.no-restricted-syntaxrule that forbade directLoginCommandcalls in tests is gone — oxlint doesn't implement that rule yet. Convention now relies on review + thesafeLogin()helper intest/__setup__/hooks/useAuthSetup.ts. Could be re-added as a custom oxlint plugin (like apify-core'soxlint_plugins/local.mjs) if desired.Lint output
Test plan
pnpm lint— cleanpnpm format— clean (still on biome + prettier for markdown)pnpm build— TypeScript + tsdown both succeed