[a3] Fix styles wtih BOM ignored by browsers, leading to UI behavior change - #5545
Merged
Conversation
BoDonkey
reviewed
Aug 4, 2026
| strategy: | ||
| matrix: | ||
| node-version: [18, 20] | ||
| node-version: [20, 22] |
Contributor
There was a problem hiding this comment.
20 is already EOL. Shouldn't this be 22, 24? Or will a3 not support 24 without further updates?
BoDonkey
previously approved these changes
Aug 4, 2026
boutell
requested changes
Aug 4, 2026
| strategy: | ||
| matrix: | ||
| node-version: [18, 20] | ||
| node-version: [20, 22] |
Contributor
Author
There was a problem hiding this comment.
24 will "bang". It requires additional work (approved hooks, the new npm tech). This was the reason I didn't touch it yet. I'll do and make it work with the new npm
| }, | ||
| "engines": { | ||
| "node": ">=16.0.0" | ||
| "node": ">=20.18.1" |
Member
|
Don't add 24, just remove 20. |
BoDonkey
approved these changes
Aug 6, 2026
boutell
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please indicate which branch this PR should merge into:
Check one
Summary
Fixed incorrect sizing and spacing across the admin UI. A byte order mark preserved by PostCSS 8.5.24 invalidated the stylesheet rule setting
line-heightandbox-sizingfor.apos-elements. Sass is now compiled withcharset: false, so the marker is never emitted.What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: