-
Notifications
You must be signed in to change notification settings - Fork 643
[a3] Fix styles wtih BOM ignored by browsers, leading to UI behavior change #5545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
615fed7
5ab45df
9ee8a8d
d44dae3
6aff3c9
ed0647c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node-version: [18, 20] | ||
| node-version: [20, 22] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bump to 22, 24
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 24 will "bang". It requires additional work (approved hooks, the new npm tech). This was the reason I didn't touch it yet. I'll do and make it work with the new npm |
||
| mongodb-version: [4.4, 5.0, 6.0, 7.0] | ||
|
|
||
| # Steps represent a sequence of tasks that will be executed as part of the job | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| "url": "git@github.com:apostrophecms/apostrophe.git" | ||
| }, | ||
| "engines": { | ||
| "node": ">=16.0.0" | ||
| "node": ">=20.18.1" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bump to 22 |
||
| }, | ||
| "keywords": [ | ||
| "apostrophe", | ||
|
|
@@ -154,7 +154,7 @@ | |
| "nyc": "^15.1.0", | ||
| "replace-in-file": "^6.1.0", | ||
| "stylelint": "^14.6.1", | ||
| "stylelint-declaration-strict-value": "^1.8.0", | ||
| "stylelint-declaration-strict-value": "~1.10.11", | ||
| "stylelint-order": "^5.0.0", | ||
| "vue-eslint-parser": "^7.1.1" | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,13 @@ | ||
| module.exports = { | ||
| root: module, | ||
| shortName: 'workspaces-project', | ||
| baseUrl: 'http://localhost:3000', | ||
| modules: { | ||
| '@apostrophecms/express': { | ||
| options: { | ||
| address: '127.0.0.1' | ||
| } | ||
| }, | ||
| '@apostrophecms/sitemap': { | ||
| options: { | ||
| baseUrl: 'http://localhost:3000' | ||
| } | ||
| } | ||
| '@apostrophecms/sitemap': {} | ||
| } | ||
| }; |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20 is already EOL. Shouldn't this be 22, 24? Or will a3 not support 24 without further updates?