fix: Ensure dns-sd is always terminated - #161
Merged
Merged
Conversation
KazuCocoa
approved these changes
Mar 16, 2026
navin772
approved these changes
Mar 16, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
## [0.34.2](v0.34.1...v0.34.2) (2026-03-16) ### Bug Fixes * Ensure dns-sd is always terminated ([#161](#161)) ([a12ff10](a12ff10))
|
🎉 This PR is included in version 0.34.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes possible issue where on exception dns-sd process is still running
initializeBrowsing() creates a long-lived browse dns-sd process (Process A) and stores it in _browseProcess.
It then awaits executeDnsSdCommand(...), which spawns a second dns-sd process (Process B) to wait for “STARTING” or timeout.
On timeout, only Process B is killed (in executeDnsSdCommand’s finally). Process A is never killed.
The error path calls cleanup(), which only clears _browseProcess and does not kill the process, so the browse child keeps the Node process alive.