Skip to content

fix: Ensure dns-sd is always terminated #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mykola-mokhnach merged 2 commits into from
Mar 16, 2026
Merged

fix: Ensure dns-sd is always terminated #161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c53653c
fix: Ensure dns-sd is always terminated
mykola-mokhnach Mar 15, 2026
4b180fd
avoid double log
mykola-mokhnach Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions src/lib/bonjour/bonjour-discovery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ export class BonjourDiscovery extends EventEmitter {
try {
await this.initializeBrowsing(serviceType, domain);
} catch (error) {
this.cleanup();
this.stopBrowsing();
throw error;
}
}
Expand All @@ -460,11 +460,19 @@ export class BonjourDiscovery extends EventEmitter {
* Stop browsing for services
*/
stopBrowsing(): void {
if (this._browseProcess && !this._browseProcess.killed) {
log.info('Stopping Bonjour discovery');
this._browseProcess.kill('SIGTERM');
if (this._browseProcess) {
log.debug('Cleaning up BonjourDiscovery resources');
if (!this._browseProcess.killed) {
try {
this._browseProcess.kill('SIGTERM');
} catch (err) {
log.warn(`Failed to kill browse process: ${err}`);
}
}
}
this.cleanup();
this._browseProcess = undefined;
this._isDiscovering = false;
this._discoveredServices.clear();
}

/**
Expand Down Expand Up @@ -603,7 +611,7 @@ export class BonjourDiscovery extends EventEmitter {
});
process.on('close', (code: number | null) => {
log.debug(`dns-sd browse process closed with code: ${code}`);
this.cleanup();
this.stopBrowsing();
});
}

Expand Down Expand Up @@ -632,14 +640,4 @@ export class BonjourDiscovery extends EventEmitter {

return devices;
}

/**
* Cleanup resources
*/
private cleanup(): void {
log.debug('Cleaning up BonjourDiscovery resources');
this._browseProcess = undefined;
this._isDiscovering = false;
this._discoveredServices.clear();
}
}
Loading