Skip to content

test: unskip Graph CoreML export tests as segfault no longer occurs - #35

Merged
guru-desh merged 1 commit into
apple:mainfrom
guru-desh:remove-coreml-segfault-test
Jul 14, 2026
Merged

test: unskip Graph CoreML export tests as segfault no longer occurs#35
guru-desh merged 1 commit into
apple:mainfrom
guru-desh:remove-coreml-segfault-test

Conversation

@guru-desh

@guru-desh guru-desh commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

We had a skipped test that was skipped due to a segfault. However, the segfault doesn't occur anymore, so we are unskipping the test

Verified across interpreter and all three CoreML delegates (CPU/BNNS,
GPU/MPSGraph, ANE) in both parallel and serial pytest runs that the
uint8/per-tensor/asymmetric quantization config no longer segfaults.
@guru-desh
guru-desh marked this pull request as ready for review July 13, 2026 09:32
@guru-desh
guru-desh requested review from crowbat and dengqiaoyu July 13, 2026 09:32
@guru-desh guru-desh added the enhancement New feature or request label Jul 13, 2026
@guru-desh guru-desh changed the title test: unskip pt2e coreml export test as segfault no longer occurs test: unskip Graph CoreML export tests as segfault no longer occurs Jul 13, 2026

@dengqiaoyu dengqiaoyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for auditing the xfailed test!

@guru-desh
guru-desh merged commit 61d7084 into apple:main Jul 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants