test: unskip eager CoreML int8-activation export tests as they now pass - #36
Merged
guru-desh merged 1 commit intoJul 14, 2026
Merged
Conversation
COREML_SUPPORTED_ACTIVATION_DTYPES already includes torch.int8 (src/coreai_opt/_utils/export_utils.py), and the CoreML rejection test (test_unsupported_activation_quant_coreml_export_rejected) already excludes int8 from its rejection list. The skip_if_unsupported guards in test_simple_model_export and test_mnist_export were stale relative to the source's own dtype-support contract. Verified all 216 previously-skipped configs now pass (CPU_ONLY, the only compute path this test file exercises).
crowbat
approved these changes
Jul 13, 2026
dengqiaoyu
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.