Skip to content

Conversation

@new-mexico-worm-farmer
Copy link
Contributor

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

The rules given on the website:
nmlottery-rules

This matches the client-side validation javascript:
nmlottery-javascript

Experimentally, I verified that they allow passwords with special characters. Technically, only one of upper or lower would be required, but it seems better to have them both as required (along with the optional special character) vs. trying to strictly encode rules that would only serve to generate weaker passwords (but willing to make changes if that's not in the spirit).

@rmondello rmondello merged commit 52d9cf1 into apple:main Sep 8, 2025
5 checks passed
@rmondello
Copy link
Contributor

@new-mexico-worm-farmer Thanks again!

@new-mexico-worm-farmer new-mexico-worm-farmer deleted the nmlottery-dot-com branch September 8, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants