Quality of Life: Add NIOLoopBoundBox.withValue
#3385
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Oct 1, 2025
Sources/NIOCore/NIOLoopBound.swift
Outdated
| /// - Returns: The value returned by the `handler` closure. | ||
| /// - Note: This method is particularly useful when you need to perform read and write operations | ||
| /// on the value because it reduces the on EventLoop checks. | ||
| public func withValue<T, E: Error>(_ handler: (inout Value) throws(E) -> T) throws(E) -> T { |
There was a problem hiding this comment.
Can we use Result and Failure instead of T and E?
Sources/NIOCore/NIOLoopBound.swift
Outdated
Comment on lines
194
to
196
| var value = self._value | ||
| defer { self._value = value } | ||
| return try handler(&value) |
There was a problem hiding this comment.
Can't we just do try handler(&self._value)?
glbrntt
approved these changes
Oct 1, 2025
|
No longer blocked, but please remove the compiler guards that are now unneeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a state machine inside the
NIOLoopBoundBoxwe currently check the EL when reading and writing. This is unnecessary. Because of this PR introduces a new withValue method, that allows users to read and write the value inside the NIOLoopBoundBox while only paying the cost for the EL check once.