-
Notifications
You must be signed in to change notification settings - Fork 704
Quality of Life: Add NIOLoopBoundBox.withValue
#3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabianfett
wants to merge
4
commits into
main
Choose a base branch
from
ff-NIOLoopBoundBox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−0
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -175,4 +175,25 @@ public final class NIOLoopBoundBox<Value>: @unchecked Sendable { | |
yield &self._value | ||
} | ||
} | ||
|
||
#if compiler(>=6.0) | ||
/// Safely access and potentially modify the contained value with a closure. | ||
/// | ||
/// This method provides a way to perform operations on the contained value while ensuring | ||
/// thread safety through EventLoop verification. The closure receives an `inout` parameter | ||
/// allowing both read and write access to the value. | ||
/// | ||
/// - Parameter handler: A closure that receives an `inout` reference to the contained value. | ||
/// The closure can read from and write to this value. Any modifications made within the | ||
/// closure will be reflected in the box after the closure completes, even if the closure throws. | ||
/// - Returns: The value returned by the `handler` closure. | ||
/// - Note: This method is particularly useful when you need to perform read and write operations | ||
/// on the value because it reduces the on EventLoop checks. | ||
public func withValue<T, E: Error>(_ handler: (inout Value) throws(E) -> T) throws(E) -> T { | ||
self.eventLoop.preconditionInEventLoop() | ||
var value = self._value | ||
defer { self._value = value } | ||
return try handler(&value) | ||
|
||
} | ||
#endif | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
Result
andFailure
instead ofT
andE
?