Fix return type of finish_transaction for jRuby
#1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipskis
added
the
bug
tombruijn
approved these changes
Sep 24, 2025
The current binding specifies `:void` as return type for `:appsignal_finish_transaction`, which means that `should_sample` returns `nil` for apps using jRuby.
lipskis
force-pushed
the
fix-jruby-extension-return-type
branch
from
1d69406 to
1cd9ea2
Compare
tombruijn
added a commit
that referenced
this pull request
Sep 25, 2025
This was the problem in #1458, where the JRuby extension returned `void` instead of a boolean. This ensure that can't happen again by testing the extension function directly. [skip changeset]
tombruijn
added a commit
that referenced
this pull request
Sep 25, 2025
This was the problem in #1458, where the JRuby extension returned `void` instead of a boolean. This ensure that can't happen again by testing the extension function directly. [skip changeset]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current binding specifies
:voidas return type for:appsignal_finish_transaction, which means thatshould_samplereturnsnilfor apps using jRuby.