Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/appsignal/integrations/code_ownership.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module CodeOwnershipIntegration
class << self
def before_complete(transaction, error)
team = ::CodeOwnership.for_backtrace(error.backtrace)
transaction.add_tags(:owner => team.name)
transaction.add_tags(:owner => team.name) if team
rescue => ex
logger = Appsignal.internal_logger
logger.error(
Expand Down
15 changes: 15 additions & 0 deletions spec/lib/appsignal/integrations/code_ownership_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,21 @@

expect(transaction).to include_tags("owner" => "GlobTeam")
end

it "handles files without owners" do
transaction = create_transaction

logs = capture_logs do
load File.join(support_dir, "code_ownership", "no_owner.rb")
rescue => error
transaction.add_error(error)
ensure
transaction.complete
end

expect(transaction).to_not include_tags("owner" => anything)
expect(logs).to be_empty
end
end
end

Expand Down
1 change: 1 addition & 0 deletions spec/support/code_ownership/no_owner.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
raise "no ownership"
Loading