Handle unowned files for code_ownership
#1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @fatkodima! I believe you're correct that this should not emit an error log line. |
unflxw
approved these changes
Oct 1, 2025
lipskis
approved these changes
Oct 1, 2025
tombruijn
approved these changes
Oct 1, 2025
lipskis
added a commit
that referenced
this pull request
Oct 1, 2025
Add a changeset for #1463, which is a community contribution. [skip review]
lipskis
added a commit
that referenced
this pull request
Oct 1, 2025
…hip-changes Add missing changeset to #1463
lipskis
added a commit
that referenced
this pull request
Oct 1, 2025
Add a changeset for #1463, which is a community contribution. [skip review]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1443.
It is perfectly fine to have unowned files, but appsignal currently produces log lines for this case, which look like some errors and can be confusing