Fix code_ownership for transactions without errors #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppSignal currently produces log lines if transaction has no errors, which look like errors and can be confusing. This change handles cases when `error` is `nil`. Follow-up to appsignal#1443
lipskis
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Thanks @fatkodima!
I will merge the PR with a squash commit and fix the line length issue that the git linter is complaining about.
lipskis
added a commit
that referenced
this pull request
Oct 2, 2025
Add a changeset for #1465, which is a community contribution. [skip ci]
lipskis
added a commit
that referenced
this pull request
Oct 2, 2025
…hip-fix Add missing changeset to #1465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found another case after #1463 was merged.
AppSignal currently produces log lines if transaction has no errors:
Follow-up to #1443.