Skip to content

Fix code_ownership for transactions without errors #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
+13 −0
Merged

Fix code_ownership for transactions without errors #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/appsignal/integrations/code_ownership.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ module Integrations
module CodeOwnershipIntegration
class << self
def before_complete(transaction, error)
return unless error

team = ::CodeOwnership.for_backtrace(error.backtrace)
transaction.add_tags(:owner => team.name) if team
rescue => ex
Expand Down
11 changes: 11 additions & 0 deletions spec/lib/appsignal/integrations/code_ownership_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,17 @@
expect(transaction).to_not include_tags("owner" => anything)
expect(logs).to be_empty
end

it "handles transactions without errors" do
transaction = create_transaction

logs = capture_logs do
transaction.complete
end

expect(transaction).to_not include_tags("owner" => anything)
expect(logs).to be_empty
end
end
end

Expand Down
Loading