Rails 8.1 fix #1473
Draft
Rails 8.1 fix #1473
+176
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c0eee2e.
Monkey patch the `ActiveSupport::Notifications` `NullHandle` so that we get events reported again. The `NullHandle` is used when no subscribers are registered. That means we get no events reported when there are no subscribers. We're not a subscriber because of a performance problem in PR #150 we decided instead to monkey patch it. See issue #1471 ## To do - This requires unit tests. - This requires testing in a real world Rails 8.1 app.
jeffkreeftmeijer
added
the
bug
|
We've found some issues with your Pull Request.
|
With ActiveSupport::Notifications::Fanout::NullHandle now existing, we have a state where ActiveSupport::Notifications::Fanout::Handle exists, but the start_finish_shared_examples will fail because the NullHandleAwareInstrumentIntegration uses the #instrument integration we use when Fanout::Handle doesn't exist. Therefor, when Fanout::NullHandle exists, we can rely on the main tests and don't have to include the start_finish ones.
jeffkreeftmeijer
force-pushed
the
rails-8.1-fix
branch
from
d1534ea to
b14f7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.