Test new enqueue and HTTP client Ruby instrumentations#371
Merged
Conversation
Add Faraday GET/POST endpoints to rails7-sidekiq so the new automated Faraday integration is exercised (and its downstream Net::HTTP event suppressed). Add chained HTTP.rb requests -- a headers chain and a followed redirect -- which run through HTTP::Session on http 6 and were previously uninstrumented. Targets: appsignal/appsignal-ruby#1523 (Faraday) appsignal/appsignal-ruby#1528 (HTTP.rb chained)
The rails6-shoryuken app only enqueued through Active Job, so the `enqueue.shoryuken` event was never recorded (Active Job suppresses it). Add a native Shoryuken worker on its own queue, enqueued from a web request, so the enqueue is recorded on the request's transaction. Targets appsignal/appsignal-ruby#1521.
Que had no test setup, so its `enqueue.que` and `bulk_enqueue.que` events went unexercised. Add a Rails 8 app on PostgreSQL with native Que jobs enqueued from a web request, including a bulk enqueue, plus Active Job (adapter :que) jobs for the `enqueue.active_job` path. Targets appsignal/appsignal-ruby#1522.
Resque had no test setup, so its `enqueue.resque` event went unexercised. Add a Rails 8 app on Redis with native Resque jobs enqueued from a web request, plus Active Job (adapter :resque) jobs for the `enqueue.active_job` path. Targets appsignal/appsignal-ruby#1525.
unflxw
force-pushed
the
jobs-http-test-setups
branch
from
July 9, 2026 10:37
1e2133b to
1d3ec71
Compare
unflxw
changed the title
This is a message from the daily scheduled checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the Ruby test setups to exercise the background-job enqueue
events and HTTP client integrations recently merged into appsignal-ruby.
Each commit below targets the specific appsignal-ruby PR it exercises.
Cover Faraday and chained HTTP.rb requests
Add Faraday GET/POST endpoints to rails7-sidekiq so the new automated
Faraday integration is exercised (and its downstream Net::HTTP event
suppressed). Add chained HTTP.rb requests -- a headers chain and a
followed redirect -- which run through HTTP::Session on http 6 and were
previously uninstrumented.
Targets:
appsignal/appsignal-ruby#1523 (Faraday)
appsignal/appsignal-ruby#1528 (HTTP.rb chained)
Exercise native Shoryuken enqueues
The rails6-shoryuken app only enqueued through Active Job, so the
enqueue.shoryukenevent was never recorded (Active Job suppresses it).Add a native Shoryuken worker on its own queue, enqueued from a web
request, so the enqueue is recorded on the request's transaction.
Targets appsignal/appsignal-ruby#1521.
Add a Que test application
Que had no test setup, so its
enqueue.queandbulk_enqueue.queevents went unexercised. Add a Rails 8 app on PostgreSQL with native
Que jobs enqueued from a web request, including a bulk enqueue, plus
Active Job (adapter :que) jobs for the
enqueue.active_jobpath.Targets appsignal/appsignal-ruby#1522.
Add a Resque test application
Resque had no test setup, so its
enqueue.resqueevent wentunexercised. Add a Rails 8 app on Redis with native Resque jobs
enqueued from a web request, plus Active Job (adapter :resque) jobs
for the
enqueue.active_jobpath.Targets appsignal/appsignal-ruby#1525.
Register Que and Resque apps in CI and README
Add the two new apps to the Ruby CI matrix and regenerate the README.