Create functions above setup/loop or prototype in Portenta flash key-value example #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setSketchStats and getSketchStats were not prototyped, so their definitions should go above setup/loop
trylaarsdam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setSketchStats and getSketchStats were not prototyped, so their definitions should go above setup/loop.
What This PR Changes
This changes the explanation of where to place the
getSketchStatsandsetSketchStatsfunctions in the Portenta Key-Value pair flash storage example. These two functions were not prototyped earlier in the example firmware, so users would get a "not declared in this scope" error if the instructions were followed to the letter.This could also be resolved by adding prototypes for the two functions in one of the earlier code snippets.
Contribution Guidelines