fix: 'Previous version' banner should redirect to#26862
Open
JiwaniZakir wants to merge 2 commits intoargoproj:masterfrom
Open
fix: 'Previous version' banner should redirect to#26862JiwaniZakir wants to merge 2 commits intoargoproj:masterfrom
JiwaniZakir wants to merge 2 commits intoargoproj:masterfrom
Conversation
…#26857) Replace hardcoded /en/stable/ link with path-relative URL that preserves the current page when redirecting to the stable docs version.
Prepend the readthedocs domain to the dynamically constructed path so that the version banner links remain absolute URLs as expected.
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
sivchari
reviewed
Mar 17, 2026
Member
sivchari
left a comment
sivchari
left a comment
There was a problem hiding this comment.
Looks good to me, but DCO is failed. Please sign to your commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26857
The version warning banner in
docs/assets/versions.jsalways linked to the stable docs home page (/en/stable/) regardless of which page the user was currently viewing. The root cause was that thehrefvalues were hardcoded tohttps://argo-cd.readthedocs.io/en/stable/in both thelatestand previous-version branches of theDOMContentLoadedlistener. Fixes this by computingstablePathusingwindow.location.pathname.replace(VERSION_REGEX, '/en/stable/')and prepending theargo-cd.readthedocs.ioorigin, so the banner link points to the equivalent page on the stable version. Verified by reviewing that the constructed URL preserves the absolute URL format expected by the original code while dynamically replacing the version segment in the path.