Skip to content

fix: 'Previous version' banner should redirect to #26862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiwaniZakir wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

fix: 'Previous version' banner should redirect to #26862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0268089
fix: version banner links to stable version of current page (#26857)
JiwaniZakir Mar 16, 2026
a6728c9
fix: use absolute URL with domain for stable version banner links
JiwaniZakir Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/assets/versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,11 @@ window.addEventListener("DOMContentLoaded", function() {
var headerHeight = document.getElementsByClassName("md-header")[0].offsetHeight;
const currentVersion = getCurrentVersion();
if (currentVersion && currentVersion !== "stable") {
var stablePath = 'https://argo-cd.readthedocs.io' + window.location.pathname.replace(VERSION_REGEX, '/en/stable/');
if (currentVersion === "latest") {
document.querySelector("div[data-md-component=announce]").innerHTML = "<div id='announce-msg'>You are viewing the docs for an unreleased version of Argo CD, <a href='https://argo-cd.readthedocs.io/en/stable/'>view the latest stable version.</a></div>";
document.querySelector("div[data-md-component=announce]").innerHTML = "<div id='announce-msg'>You are viewing the docs for an unreleased version of Argo CD, <a href='" + stablePath + "'>view the latest stable version.</a></div>";
Copy link
Contributor

@olivergondza olivergondza Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind inserting portions of unescaped window.location.pathname is not secure: http://172.17.0.2:8000/en/latest/'onclick=javascript:alert(999999);//.

I am thinking if referring to or repeating the version selection widget would not be preferable.

} else {
document.querySelector("div[data-md-component=announce]").innerHTML = "<div id='announce-msg'>You are viewing the docs for a previous version of Argo CD, <a href='https://argo-cd.readthedocs.io/en/stable/'>view the latest stable version.</a></div>";
document.querySelector("div[data-md-component=announce]").innerHTML = "<div id='announce-msg'>You are viewing the docs for a previous version of Argo CD, <a href='" + stablePath + "'>view the latest stable version.</a></div>";
}
var bannerHeight = document.getElementById('announce-msg').offsetHeight + margin;
document.querySelector("header.md-header").style.top = bannerHeight + "px";
Expand Down
Loading