ci(gitops-engine): support tagged releases for gitops-engine#27740
ci(gitops-engine): support tagged releases for gitops-engine#27740rumstead wants to merge 3 commits intoargoproj:masterfrom
Conversation
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27740 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 421 421
Lines 57657 57657
=======================================
+ Hits 36834 36836 +2
+ Misses 17363 17362 -1
+ Partials 3460 3459 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses downstream Go module resolution failures by moving Argo CD’s github.com/argoproj/argo-cd/gitops-engine dependency toward using a tag that can be fetched outside this repo (instead of an invalid/unstable pseudo-version), and by extending the release automation to create and reference a path-prefixed gitops-engine tag.
Changes:
- Update root
go.modto a new gitops-engine pseudo-version and document the intent to use path-prefixed tags. - Extend the release workflow to publish a
gitops-engine/<tag>tag alongside the Argo CD release tag. - Extend the init-release workflow to rewrite the gitops-engine requirement in
go.modto the release tag version during release preparation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| go.mod | Updates the required gitops-engine version and documents the intended tag scheme for downstream consumption. |
| .github/workflows/release.yaml | Adds logic to create/push a path-prefixed gitops-engine tag during the post-release steps. |
| .github/workflows/init-release.yaml | Adds automation to rewrite the gitops-engine require entry to a release tag during release branch prep. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Update the require line to reference the gitops-engine tag that will be created at release time | ||
| # Handles both semver (v3.4.1) and pseudo-versions (v0.0.0-20260212142940-0cdd44bda77a) | ||
| GE_VERSION="v${{ inputs.TARGET_VERSION }}" | ||
| sed -i "s|github.com/argoproj/argo-cd/gitops-engine v[^ ]*|github.com/argoproj/argo-cd/gitops-engine ${GE_VERSION}|" go.mod | ||
|
|
| # Create a path-prefixed tag for gitops-engine | ||
| # so downstream consumers can resolve github.com/argoproj/argo-cd/gitops-engine | ||
| # https://go.dev/doc/modules/managing-source#multiple-module-source | ||
| GE_TAG="gitops-engine/${{ github.ref_name }}" |
| github.com/TomOnTime/utfutil v1.0.0 | ||
| github.com/alicebob/miniredis/v2 v2.37.0 | ||
| github.com/argoproj/argo-cd/gitops-engine v0.7.1-0.20250908182407-97ad5b59a627 | ||
| github.com/argoproj/argo-cd/gitops-engine v0.0.0-20260507145512-134b428d78ca // Tagged as gitops-engine/vX.Y.Z at release time |
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
closes #27725
Checklist: