Skip to content

ci(gitops-engine): support tagged releases for gitops-engine#27740

Draft
rumstead wants to merge 3 commits intoargoproj:masterfrom
rumstead:feat/support-gitops-engine-versioning
Draft

ci(gitops-engine): support tagged releases for gitops-engine#27740
rumstead wants to merge 3 commits intoargoproj:masterfrom
rumstead:feat/support-gitops-engine-versioning

Conversation

@rumstead
Copy link
Copy Markdown
Member

@rumstead rumstead commented May 7, 2026

closes #27725

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented May 7, 2026

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.88%. Comparing base (3a2e2f6) to head (873bf01).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27740   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files         421      421           
  Lines       57657    57657           
=======================================
+ Hits        36834    36836    +2     
+ Misses      17363    17362    -1     
+ Partials     3460     3459    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses downstream Go module resolution failures by moving Argo CD’s github.com/argoproj/argo-cd/gitops-engine dependency toward using a tag that can be fetched outside this repo (instead of an invalid/unstable pseudo-version), and by extending the release automation to create and reference a path-prefixed gitops-engine tag.

Changes:

  • Update root go.mod to a new gitops-engine pseudo-version and document the intent to use path-prefixed tags.
  • Extend the release workflow to publish a gitops-engine/<tag> tag alongside the Argo CD release tag.
  • Extend the init-release workflow to rewrite the gitops-engine requirement in go.mod to the release tag version during release preparation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
go.mod Updates the required gitops-engine version and documents the intended tag scheme for downstream consumption.
.github/workflows/release.yaml Adds logic to create/push a path-prefixed gitops-engine tag during the post-release steps.
.github/workflows/init-release.yaml Adds automation to rewrite the gitops-engine require entry to a release tag during release branch prep.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +66 to +70
# Update the require line to reference the gitops-engine tag that will be created at release time
# Handles both semver (v3.4.1) and pseudo-versions (v0.0.0-20260212142940-0cdd44bda77a)
GE_VERSION="v${{ inputs.TARGET_VERSION }}"
sed -i "s|github.com/argoproj/argo-cd/gitops-engine v[^ ]*|github.com/argoproj/argo-cd/gitops-engine ${GE_VERSION}|" go.mod

# Create a path-prefixed tag for gitops-engine
# so downstream consumers can resolve github.com/argoproj/argo-cd/gitops-engine
# https://go.dev/doc/modules/managing-source#multiple-module-source
GE_TAG="gitops-engine/${{ github.ref_name }}"
Comment thread .github/workflows/release.yaml Outdated
Comment thread go.mod
github.com/TomOnTime/utfutil v1.0.0
github.com/alicebob/miniredis/v2 v2.37.0
github.com/argoproj/argo-cd/gitops-engine v0.7.1-0.20250908182407-97ad5b59a627
github.com/argoproj/argo-cd/gitops-engine v0.0.0-20260507145512-134b428d78ca // Tagged as gitops-engine/vX.Y.Z at release time
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid gitops-engine version in v3.4.1

2 participants