-
Notifications
You must be signed in to change notification settings - Fork 7.2k
ci(gitops-engine): support tagged releases for gitops-engine #27740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rumstead
wants to merge
19
commits into
argoproj:master
Choose a base branch
from
rumstead:feat/support-gitops-engine-versioning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
953b40c
ci(gitops-engine): support tagged releases for gitops-engine
rumstead 7d03367
ci(gitops-engine): support tagged releases for gitops-engine
rumstead 873bf01
make tag push idempotent
rumstead 4eaa6dd
look at origin for tags
rumstead 53c3d0c
feat: support v3 of gitops-engine
rumstead c0ac14b
feat: codegen
rumstead 364ad81
update docs to not use /v3 and fix sed command to not touch comments
rumstead be86d6c
Merge remote-tracking branch 'upstream/master' into feat/support-gito…
rumstead 6432917
fix missed gitops-engine bump and merge HEAD
rumstead 405ad16
copilot review suggestions
rumstead 55ee10b
copilot review suggestions
rumstead 34c86ae
update comment in release.yaml
rumstead 1a8537a
update comment in release.yaml
rumstead 5f24d9c
update comment in release.yaml
rumstead b70d0bb
update comment in release.yaml
rumstead 847624c
Merge branch 'master' into feat/support-gitops-engine-versioning
rumstead a1b7457
revert testing gitops-engine tag, update init-release to support majo…
rumstead 1ecadd7
Merge branch 'feat/support-gitops-engine-versioning' of github.com:ru…
rumstead 535f443
fix go mod
rumstead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,17 +7,17 @@ on: | |
| - '!v2.5*' | ||
| - '!v2.6*' | ||
|
|
||
| permissions: {} | ||
| permissions: { } | ||
|
|
||
| env: | ||
| # renovate: datasource=golang-version packageName=golang | ||
| GOLANG_VERSION: '1.26.3' # Note: go-version must also be set in job argocd-image.with.go-version | ||
| # a workaround to disable harden runner | ||
| STEP_SECURITY_HARDEN_RUNNER: ${{ vars.disable_harden_runner }} | ||
|
|
||
| jobs: | ||
| argocd-image: | ||
| needs: [setup-variables] | ||
| needs: [ setup-variables ] | ||
| permissions: | ||
| contents: read | ||
| id-token: write # for creating OIDC tokens for signing. | ||
|
|
@@ -101,7 +101,7 @@ jobs: | |
| echo "allow_fork_release=$ALLOW_FORK_RELEASE" >> $GITHUB_OUTPUT | ||
|
|
||
| argocd-image-provenance: | ||
| needs: [setup-variables, argocd-image] | ||
| needs: [ setup-variables, argocd-image ] | ||
| permissions: | ||
| actions: read # for detecting the Github Actions environment. | ||
| id-token: write # for creating OIDC tokens for signing. | ||
|
|
@@ -193,7 +193,7 @@ jobs: | |
| echo "hashes=$hashes" >> $GITHUB_OUTPUT | ||
|
|
||
| goreleaser-provenance: | ||
| needs: [goreleaser, setup-variables] | ||
| needs: [ goreleaser, setup-variables ] | ||
| permissions: | ||
| actions: read # for detecting the Github Actions environment | ||
| id-token: write # Needed for provenance signing and ID | ||
|
|
@@ -293,7 +293,7 @@ jobs: | |
| /tmp/sbom.tar.gz | ||
|
|
||
| sbom-provenance: | ||
| needs: [generate-sbom, setup-variables] | ||
| needs: [ generate-sbom, setup-variables ] | ||
| permissions: | ||
| actions: read # for detecting the Github Actions environment | ||
| id-token: write # Needed for provenance signing and ID | ||
|
|
@@ -313,7 +313,7 @@ jobs: | |
| - goreleaser | ||
| - generate-sbom | ||
| permissions: | ||
| contents: write # Needed to push commit to update stable tag | ||
| contents: write # Needed to push commit to update stable and gitops-engine tags | ||
| pull-requests: write # Needed to create PR for VERSION update. | ||
| if: github.repository == 'argoproj/argo-cd' || needs.setup-variables.outputs.allow_fork_release == 'true' | ||
| runs-on: ubuntu-24.04 | ||
|
|
@@ -338,6 +338,16 @@ jobs: | |
| git push -f origin stable | ||
| if: ${{ env.TAG_STABLE == 'true' }} | ||
|
|
||
| - name: Tag gitops-engine submodule | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needs review |
||
| run: | | ||
| set -xue | ||
| # Create a path-prefixed tag for gitops-engine | ||
| # so downstream consumers can resolve github.com/argoproj/argo-cd/gitops-engine | ||
|
rumstead marked this conversation as resolved.
Outdated
rumstead marked this conversation as resolved.
Outdated
|
||
| # https://go.dev/doc/modules/managing-source#multiple-module-source | ||
| GE_TAG="gitops-engine/${{ github.ref_name }}" | ||
|
rumstead marked this conversation as resolved.
|
||
| git tag "${GE_TAG}" ${{ github.ref_name }} | ||
| git push origin "${GE_TAG}" | ||
|
rumstead marked this conversation as resolved.
Outdated
|
||
|
|
||
| - name: Check to see if VERSION should be updated on master branch | ||
| run: | | ||
| set -xue | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs review