docs: Include instructions on enable Remoteproc Runtime in userspace#15
Conversation
adcd1a6 to
c5f6801
Compare
edc99ee to
bc92a6f
Compare
|
The CI test of this PR is dependent on this change - arm/remoteproc-simulator#2 |
muchzill4
left a comment
There was a problem hiding this comment.
Everywhere we use fmt.Println we should aim to use logger instead.
In order to make some incremental progress here - it's been a bit of a drag - I suggest we split this PR. I worry that tackling the logging properly will balloon this further. We should also consider how we test the features added here.
Something we could land as a separate change is respecting the /sys/.../parameters/path. This does not rely on root or non-root.
Remoteproc Runtime uses Remoteproc, which usually requires root permissions to write to its filesystem. To ensure that Remoteproc Runtime has root access, the container engines that spawn containers with Remoteproc Runtime should be run with root access. Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enables Remoteproc Runtime to be usable by non-root users by removing hard-coded root-only paths and providing configuration guidance. The changes focus on documentation to help users set up proper permissions for running the runtime in user space.
- Added permission setting documentation for non-root user access
- Updated usage documentation to reference new permission requirements
- Provided instructions for configuring remoteproc driver access and firmware paths
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/USAGE.md | Added note about elevated permissions requirement with link to permission setup guide |
| docs/PERMISSION_SETTING.md | New comprehensive guide for configuring non-root user access to remoteproc driver and firmware paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: yejseo01 <yejseo01@arm.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: yejseo01 <yejseo01@arm.com>
Co-authored-by: Luke Parkin <65398091+Luke-Parkin@users.noreply.github.com> Signed-off-by: yejseo01 <yejseo01@arm.com>
Co-authored-by: Luke Parkin <65398091+Luke-Parkin@users.noreply.github.com> Signed-off-by: yejseo01 <yejseo01@arm.com>
Co-authored-by: Luke Parkin <65398091+Luke-Parkin@users.noreply.github.com> Signed-off-by: yejseo01 <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Co-authored-by: James Cox-Morton <Th3james@fastmail.fm> Signed-off-by: yejseo01 <yejseo01@arm.com>
Co-authored-by: James Cox-Morton <Th3james@fastmail.fm> Signed-off-by: yejseo01 <yejseo01@arm.com>
Co-authored-by: James Cox-Morton <Th3james@fastmail.fm> Signed-off-by: yejseo01 <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
All requested changes applied
Changes
Update document to include information on enabling Remoteproc Runtime run in userspace
Checklist