feat: Seek firmware from path specified in kernel parameter path filesystem#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the firmware loading mechanism to read the firmware directory path from /sys/module/firmware_class/parameters/path instead of hardcoding /lib/firmware. This makes the simulator more flexible and aligned with how Linux actually determines firmware locations.
Key changes:
- Modified FileSystemManager to track and create the firmware path configuration file
- Updated tests to dynamically read firmware directory from the system parameter file
- Added mkfile() helper to create parent directories and files atomically
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pkg/simulator/filesystem.go | Added firmware path file tracking, mkfile() helper, and verification logic to read firmware directory from system parameters |
| e2e/running_firmware_test.go | Updated test to read firmware directory from system parameter file instead of hardcoded path |
| e2e/boostrapping_test.go | Modified bootstrapping test to verify firmware directory based on system parameter file |
| cmd/remoteproc-simulator/main.go | Updated documentation to remove assumption about /lib directory creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
3 tasks
th3james
reviewed
Oct 28, 2025
Luke-Parkin
reviewed
Oct 29, 2025
Luke-Parkin
reviewed
Oct 29, 2025
Luke-Parkin
approved these changes
Oct 29, 2025
Luke-Parkin
requested changes
Oct 29, 2025
Luke-Parkin
approved these changes
Oct 29, 2025
federicobozzini
approved these changes
Oct 29, 2025
…/parameters/path Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
yejseo01
force-pushed
the
firmware_path
branch
from
October 29, 2025 11:14
dd589de to
bf048cf
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/sys/module/firmware_class/parameters/path/sys/module/firmware_class/parameters/path/sys/module/firmware_class/parameters/pathand the actual firmware path/sys/module/firmware_class/parameters/pathChecklist