Fix type hints for interval and span_range to accept Arrow objects#1255
Open
rstar327 wants to merge 2 commits intoarrow-py:masterfrom
Open
Fix type hints for interval and span_range to accept Arrow objects#1255rstar327 wants to merge 2 commits intoarrow-py:masterfrom
rstar327 wants to merge 2 commits intoarrow-py:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.Description of Changes
Arrow.intervalandArrow.span_rangeacceptArrowobjects forstartandendparameters, but the type hints only specifieddatetime.datetime. This causes false type errors in type checkers like mypy/pyright.Updated type hints from
dt_datetimetoUnion["Arrow", dt_datetime]for both methods, matching the existing pattern used inArrow.range.Added
test_arrow_objects_as_start_endto verifyArrowobjects work correctly withinterval. All 1905 tests pass.Closes: #1210