Skip to content

Fix type hints for interval and span_range to accept Arrow objects #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rstar327 wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −6
Open

Fix type hints for interval and span_range to accept Arrow objects #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48d02d8
fix(types): accept Arrow objects in interval and span_range type hints
rstar327 Feb 26, 2026
84d04f6
fix(types): use _get_datetime for mypy compatibility
rstar327 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions arrow/arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,8 @@ def ceil(self, frame: _T_FRAMES, **kwargs: Any) -> "Arrow":
def span_range(
cls,
frame: _T_FRAMES,
start: dt_datetime,
end: dt_datetime,
start: Union["Arrow", dt_datetime],
end: Union["Arrow", dt_datetime],
tz: Optional[TZ_EXPR] = None,
limit: Optional[int] = None,
bounds: _BOUNDS = "[)",
Expand Down Expand Up @@ -702,8 +702,10 @@ def span_range(
"""

tzinfo = cls._get_tzinfo(start.tzinfo if tz is None else tz)
start = cls.fromdatetime(start, tzinfo).span(frame, exact=exact)[0]
end = cls.fromdatetime(end, tzinfo)
start = cls.fromdatetime(cls._get_datetime(start), tzinfo).span(
frame, exact=exact
)[0]
end = cls.fromdatetime(cls._get_datetime(end), tzinfo)
_range = cls.range(frame, start, end, tz, limit)
if not exact:
for r in _range:
Expand All @@ -725,8 +727,8 @@ def span_range(
def interval(
cls,
frame: _T_FRAMES,
start: dt_datetime,
end: dt_datetime,
start: Union["Arrow", dt_datetime],
end: Union["Arrow", dt_datetime],
interval: int = 1,
tz: Optional[TZ_EXPR] = None,
bounds: _BOUNDS = "[)",
Expand Down
20 changes: 20 additions & 0 deletions tests/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,26 @@ def test_exact(self):

assert result == expected

def test_arrow_objects_as_start_end(self):
start = arrow.Arrow(2013, 5, 5, 12, 30)
end = arrow.Arrow(2013, 5, 5, 17, 15)
result = list(arrow.Arrow.interval("hour", start, end, 2))

assert result == [
(
arrow.Arrow(2013, 5, 5, 12),
arrow.Arrow(2013, 5, 5, 13, 59, 59, 999999),
),
(
arrow.Arrow(2013, 5, 5, 14),
arrow.Arrow(2013, 5, 5, 15, 59, 59, 999999),
),
(
arrow.Arrow(2013, 5, 5, 16),
arrow.Arrow(2013, 5, 5, 17, 59, 59, 999999),
),
]


@pytest.mark.usefixtures("time_2013_02_15")
class TestArrowSpan:
Expand Down
Loading