Add margin-top to p elements in accordion [PUB-306]#724
Merged
web-dev-trev merged 3 commits intodevelopfrom Mar 27, 2025
Merged
Add margin-top to p elements in accordion [PUB-306]#724web-dev-trev merged 3 commits intodevelopfrom
web-dev-trev merged 3 commits intodevelopfrom
Conversation
zachgarwood
reviewed
Mar 27, 2025
| 'value' => '/collection/articlesPublications/digitalPublicationsBrowser/articles/browser?digitalPublication=' . $item->id | ||
| ] | ||
| ]" | ||
| :params="[ 'digitalPublication' => $item->id, ]" |
Member
There was a problem hiding this comment.
I submitted a PR to Twill to actually implement the :params option:
area17/twill#2752
Member
Author
There was a problem hiding this comment.
oh... well this works and i needed to update the url path anyway 🤷
web-dev-trev
force-pushed
the
fix/ranged-accordion-headers
branch
from
5021026 to
c81b4b9
Compare
|
nikhiltri
pushed a commit
that referenced
this pull request
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.