Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin-top to p elements in accordion [PUB-306] #724

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

web-dev-trev
Copy link
Member

No description provided.

@web-dev-trev web-dev-trev self-assigned this Mar 27, 2025
]
]"
:params="[ 'digitalPublication' => $item->id, ]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a PR to Twill to actually implement the :params option:
area17/twill#2752

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... well this works and i needed to update the url path anyway 🤷

Copy link
Member

@zachgarwood zachgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@web-dev-trev web-dev-trev force-pushed the fix/ranged-accordion-headers branch from 5021026 to c81b4b9 Compare March 27, 2025 22:15
@web-dev-trev web-dev-trev merged commit 4ed9399 into develop Mar 27, 2025
5 of 6 checks passed
@web-dev-trev web-dev-trev deleted the fix/ranged-accordion-headers branch March 27, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants