Skip to content

Add margin-top to p elements in accordion [PUB-306] #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
web-dev-trev merged 3 commits into from
Mar 27, 2025
Merged

Add margin-top to p elements in accordion [PUB-306] #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d54e63f
Add margin-top to p elements in accordion [PUB-306]
web-dev-trev Mar 27, 2025
8dfdd41
Update group of entries limit [PUB-304]
web-dev-trev Mar 27, 2025
c81b4b9
FIx browser link for digipub articles [PUB-304]
web-dev-trev Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/scss/organisms/_o-accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
margin-top: 40px;
}

.o-accordion__panel-content {
h4 {
margin-bottom: 12px !important;
}
}

h3 {
border-top: 1px solid $color__rules--primary;
padding: 16px 0 !important;
Expand Down
2 changes: 1 addition & 1 deletion resources/views/site/digitalPublicationDetail.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@
@foreach ($topLevelArticle->children->filter(function($item) {
return !$item->suppress_listing;
})->sortBy('position') as $item)
@if($loop->iteration <= 9 || $showAll == true)
@if($loop->iteration <= 12 || $showAll == true)
@component('components.molecules._m-listing----cover')
@slot('variation', 'm-listing--cover--digital-publication')
@slot('href', route(
Expand Down
5 changes: 2 additions & 3 deletions resources/views/twill/digitalPublications/form.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,10 @@
:endpoints="[
[
'label' => 'Articles',
'value' => '/collection/articlesPublications/digitalPublications/articles/subbrowser'
'value' => '/collection/articlesPublications/digitalPublicationsBrowser/articles/browser?digitalPublication=' . $item->id
]
]"
:params="[ 'digitalPublication' => $item->id, ]"
Copy link
Member

@zachgarwood zachgarwood Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a PR to Twill to actually implement the :params option:
area17/twill#2752

Copy link
Member Author

@web-dev-trev web-dev-trev Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... well this works and i needed to update the url path anyway 🤷

/>
/>

<x-twill::wysiwyg
name='sponsor_display'
Expand Down
Loading