Repository navigation
fix: bump vulnerable transitive dependencies - #13841
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates JavaScript and Ruby lockfiles (and adds/adjusts Yarn resolutions) to remediate high-severity Dependabot alerts across Eigen’s main workspace and the bin/ (eas-cli tooling) workspace.
Changes:
- Bump multiple vulnerable transitive JS dependencies in
yarn.lockvia a mix ofyarn upandresolutions(e.g. postcss, fast-xml-parser, sharp, tmp, ws, path-to-regexp, js-yaml). - Add/expand
dependenciesCommentsandresolutionsentries inpackage.jsonto document and enforce overrides that upstream packages currently prevent. - Update Ruby locked gems in
Gemfile.lock(concurrent-ruby, faraday, jwt). - Partially bump
bin/workspace dependencies inbin/yarn.lock(e.g. picomatch, node-forge descriptors).
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yarn.lock | Updates resolved JS dependency graph to patched versions; introduces new/updated transitive entries consistent with added resolutions. |
| package.json | Adds documented resolutions (postcss/fast-xml-parser/sharp/tmp) and bumps react-use range to allow patched transitive deps. |
| Gemfile.lock | Bumps a small set of Ruby gems to patched versions. |
| bin/yarn.lock | Updates bin/ workspace lock entries for tooling dependencies (notably adds a node-forge@1.4.0 descriptor, but retains 1.3.1). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
These will be handled separately from the JS-focused dependency bump PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
| linkType: hard | ||
|
|
||
| "node-forge@npm:1.3.1, node-forge@npm:^1.2.1, node-forge@npm:^1.3.1": | ||
| "node-forge@npm:1.3.1": |
There was a problem hiding this comment.
node-forge@npm:1.3.1 is still resolved to 1.3.1 here — the yarn up only moved the ^1.2.1 / ^1.3.1 ranges. The exact 1.3.1 descriptor comes from eas-cli@16.9.0 (bin/yarn.lock:1624, node-forge: "npm:1.3.1"), so the vulnerable copy stays in the tree and alerts #222/#317/#318/#319 won't close.
bin/package.json already has the pattern for exactly this case ("minimatch@npm:5.1.2": "5.1.8", "tar@npm:6.2.1": "7.5.22"). Add:
"node-forge@npm:1.3.1": "1.4.0"plus a dependenciesComments entry to match the others.
| "react-relay": "18.2.0", | ||
| "react-tracking": "9.3.2", | ||
| "react-use": "17.6.0", | ||
| "react-use": "^17.6.1", |
There was a problem hiding this comment.
This caret is the only ranged version in the whole file — every other entry in dependencies and devDependencies is an exact pin. .yarnrc.yml doesn't set defaultSemverRangePrefix: "", so yarn up added the ^ on its own rather than by intent. Pin it to match everything else:
| "react-use": "^17.6.1", | |
| "react-use": "17.6.1", |
|
Code Review Summary Closes the remaining open high-severity Dependabot alerts by bumping transitive deps in Verified in the lock: Issues Found 🟡 The
🟡 Every other entry across The 🟡
Areas Reviewed Security — the point of the PR. Scope checks out:
Comment accuracy — spot-checked the Testing — nothing to add; dependency-only. Questions for Author
|
This PR resolves PHIRE-3321
Description
Follow-up to #13838 and #13840. Addresses the remaining open high-severity Dependabot alerts across
yarn.lockandbin/yarn.lock(theeas-clitooling workspace).resolutionsresolutionsyarn upyarn upyarn upyarn upyarn up(unblocks path-to-regexp below)yarn up(via express bump)yarn up(unblocks js-cookie below)yarn up(via react-use bump)resolutionsresolutionsWhere a dependency's requester pins a narrower range that excludes the patched version, a
resolutionsoverride was added (following the existingshell-quotepattern), with a comment explaining why and what to remove it once fixed upstream:expo(via@expo/metro-config@55.0.21) exact-pinspostcss@~8.4.32, andstyled-components@6.1.19exact-pinspostcss@8.4.49; neither is patched.react-native-bootsplash@7.1.0exact-caret-pinssharp@^0.34.5(excludes0.35.0). We're intentionally not bumpingreact-native-bootsplashitself in this PR — that would require7.3.2+, a native-touching config-plugin bump worth its own testing pass — remove this resolution once that bump happens.@artsy/update-repo@0.8.2(latest available) exact-pinstmp@^0.1.0, and no patched release exists on that line (patched is0.2.6+). Remove once@artsy/update-repobumps itstmpdependency upstream.Known follow-up (not fixed here)
danger@11.2.3(our Dangerfile CI tool). The only fix path is a major bump todanger@13.0.10, which drops the dependency entirely — deferred to a separate PR since it needs its own compatibility pass againstdangerfile.tsand CI.All 19 scanned high-severity alerts have been assigned to me for tracking.
PR Checklist
To the reviewers 👀
#nochangelog
🤖 Generated with Claude Code