Skip to content

fix: bump vulnerable transitive dependencies #13841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkartalis merged 2 commits into from
Jul 29, 2026
Merged

fix: bump vulnerable transitive dependencies #13841

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c245a0
fix: bump vulnerable transitive dependencies (postcss, sharp, tmp, js…
gkartalis Jul 28, 2026
d04d9e3
revert: drop Ruby dependency bumps (concurrent-ruby, faraday, jwt)
gkartalis Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ GEM
colored2 (3.1.2)
commander (4.6.0)
highline (~> 2.0.0)
concurrent-ruby (1.2.2)
concurrent-ruby (1.3.8)
Comment thread
github-actions[bot] marked this conversation as resolved.
Outdated
csv (3.3.5)
declarative (0.0.20)
digest-crc (0.7.0)
Expand All @@ -107,7 +107,7 @@ GEM
ethon (0.16.0)
ffi (>= 1.15.0)
excon (0.112.0)
faraday (1.10.5)
faraday (1.10.6)
faraday-em_http (~> 1.0)
faraday-em_synchrony (~> 1.0)
faraday-excon (~> 1.1)
Expand Down Expand Up @@ -251,7 +251,7 @@ GEM
concurrent-ruby (~> 1.0)
jmespath (1.6.2)
json (2.19.5)
jwt (2.10.2)
jwt (2.10.3)
base64
logger (1.7.0)
lowdown (1.0.0)
Expand Down
15 changes: 11 additions & 4 deletions bin/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3120,13 +3120,20 @@ __metadata:
languageName: node
linkType: hard

"node-forge@npm:1.3.1, node-forge@npm:^1.2.1, node-forge@npm:^1.3.1":
"node-forge@npm:1.3.1":
Comment thread
github-actions[bot] marked this conversation as resolved.

@claude claude Bot Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-forge@npm:1.3.1 is still resolved to 1.3.1 here — the yarn up only moved the ^1.2.1 / ^1.3.1 ranges. The exact 1.3.1 descriptor comes from eas-cli@16.9.0 (bin/yarn.lock:1624, node-forge: "npm:1.3.1"), so the vulnerable copy stays in the tree and alerts #222/#317/#318/#319 won't close.

bin/package.json already has the pattern for exactly this case ("minimatch@npm:5.1.2": "5.1.8", "tar@npm:6.2.1": "7.5.22"). Add:

"node-forge@npm:1.3.1": "1.4.0"

plus a dependenciesComments entry to match the others.

version: 1.3.1
resolution: "node-forge@npm:1.3.1"
checksum: 10c0/e882819b251a4321f9fc1d67c85d1501d3004b4ee889af822fd07f64de3d1a8e272ff00b689570af0465d65d6bf5074df9c76e900e0aff23e60b847f2a46fbe8
languageName: node
linkType: hard

"node-forge@npm:^1.2.1, node-forge@npm:^1.3.1":
version: 1.4.0
resolution: "node-forge@npm:1.4.0"
checksum: 10c0/67330a5f1f95257a4c8a93b7d555abe87b5f15e350123aa396c97a21a8ca94f9c6549008eb2c73668a91e0d7e3a905785acbd8f8bd0751c29401292011f8f8e1
languageName: node
linkType: hard

"node-gyp@npm:latest":
version: 11.4.2
resolution: "node-gyp@npm:11.4.2"
Expand Down Expand Up @@ -3421,9 +3428,9 @@ __metadata:
linkType: hard

"picomatch@npm:^4.0.3":
version: 4.0.3
resolution: "picomatch@npm:4.0.3"
checksum: 10c0/9582c951e95eebee5434f59e426cddd228a7b97a0161a375aed4be244bd3fe8e3a31b846808ea14ef2c8a2527a6eeab7b3946a67d5979e81694654f939473ae2
version: 4.0.5
resolution: "picomatch@npm:4.0.5"
checksum: 10c0/947bc6b6e1ff1e6c5aaf95b107a0839d12802f4f7b867663f67d47accba939ca1cb582cf99dfc30438efa1c4648ac5990967e783e8929c36b03e8440704ef1bd
languageName: node
linkType: hard

Expand Down
13 changes: 10 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@
"react-native": "Try running `npx @rnx-kit/align-deps --requirements react-native@0.66.5` when upgrading to a version, here 0.66.5",
"@babel/plugin-transform-named-capturing-groups-regex": "Needed for compiling android with hermes enabled",
"braces": "in the resolutions - needed to resolve a security dependency issue - need to remove this when the issue is resolved and packages are updated",
"shell-quote": "Pinned to 1.9.0 to fix GHSA-w7jw-789q-3m8p (critical) and GHSA-395f-4hp3-45gv (ReDoS). @segment/sovran-react-native exact-pins the vulnerable 1.8.0 with no fixed release; remove this once Segment bumps it upstream."
"shell-quote": "Pinned to 1.9.0 to fix GHSA-w7jw-789q-3m8p (critical) and GHSA-395f-4hp3-45gv (ReDoS). @segment/sovran-react-native exact-pins the vulnerable 1.8.0 with no fixed release; remove this once Segment bumps it upstream.",
"postcss": "Pinned to fix GHSA-6g55-p6wh-862q and GHSA-r28c-9q8g-f849 (path traversal / arbitrary file disclosure via sourceMappingURL). expo (via @expo/metro-config@55.0.21) exact-pins postcss@~8.4.32, and styled-components@6.1.19 exact-pins postcss@8.4.49, neither of which is patched; remove this once expo/styled-components bump their postcss dependency upstream.",
"fast-xml-parser": "Bumped from 5.3.7 to 5.5.6 to additionally fix GHSA-8gc5-j5rx-235r (numeric entity expansion bypassing entity expansion limits); see comment history for the original CVE this resolution addressed.",
Comment thread
github-actions[bot] marked this conversation as resolved.
"sharp": "Pinned to 0.35.0 to fix GHSA-f88m-g3jw-g9cj. react-native-bootsplash@7.1.0 exact-caret-pins sharp@^0.34.5 (excludes 0.35.0); remove this once react-native-bootsplash is bumped to 7.3.2+ (which requires sharp@^0.35.2).",
"tmp": "Pinned to 0.2.7 to fix GHSA-ph9p-34f9-6g65 (arbitrary file/directory write via symlink). @artsy/update-repo@0.8.2 (latest) exact-pins tmp@^0.1.0 with no patched release on that line; remove this once @artsy/update-repo bumps its tmp dependency upstream."
},
"dependencies": {
"@artsy/changelog": "0.1.0",
Expand Down Expand Up @@ -210,7 +214,7 @@
"react-native-youtube-iframe": "2.4.1",
"react-relay": "18.2.0",
"react-tracking": "9.3.2",
"react-use": "17.6.0",
"react-use": "^17.6.1",
Comment thread
github-actions[bot] marked this conversation as resolved.

@claude claude Bot Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caret is the only ranged version in the whole file — every other entry in dependencies and devDependencies is an exact pin. .yarnrc.yml doesn't set defaultSemverRangePrefix: "", so yarn up added the ^ on its own rather than by intent. Pin it to match everything else:

Suggested change
"react-use": "^17.6.1",
"react-use": "17.6.1",

"remove-markdown": "0.5.0",
"semver": "7.5.2",
"sift-react-native": "patch:sift-react-native@npm%3A0.1.15#~/.yarn/patches/sift-react-native-npm-0.1.15-61730a007d.patch",
Expand Down Expand Up @@ -350,7 +354,10 @@
"braces": "3.0.3",
"shell-quote": "1.9.0",
"@jest/fake-timers@npm:^29.7.0": "patch:@jest/fake-timers@npm%3A29.7.0#~/.yarn/patches/@jest-fake-timers-npm-29.7.0-e4174d1b56.patch",
"fast-xml-parser": "5.3.7"
"fast-xml-parser": "5.5.6",
"postcss": "8.5.23",
"sharp": "0.35.0",
"tmp": "0.2.7"
},
"pull-lock": {
"ios/Podfile.lock": "echo \"🚨 New Podfile.lock detected!, you might need to run yarn install:all\" 🚨",
Expand Down
Loading
Loading