Skip to content

only validate the new entry in add_history_entry#2029

Merged
braingram merged 3 commits into
asdf-format:mainfrom
braingram:validate_history
Apr 23, 2026
Merged

only validate the new entry in add_history_entry#2029
braingram merged 3 commits into
asdf-format:mainfrom
braingram:validate_history

Conversation

@braingram
Copy link
Copy Markdown
Contributor

@braingram braingram commented Apr 22, 2026

Description

Closes #1736

Remove the whole-tree validation in add_history_entry and replace it with validation of the newly created HistoryEntry.

Tasks

  • run pre-commit on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review April 22, 2026 14:03
@braingram braingram requested a review from a team as a code owner April 22, 2026 14:03
@braingram braingram requested a review from sydduckworth April 23, 2026 12:57
@braingram braingram mentioned this pull request Apr 23, 2026
@braingram braingram enabled auto-merge April 23, 2026 17:42
@braingram braingram merged commit 1874f88 into asdf-format:main Apr 23, 2026
57 checks passed
@braingram braingram deleted the validate_history branch April 23, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add_history_entry validates the entire tree

2 participants