Conversation
…bare `:retry` When `compensate/4` returns bare `:retry`, `backoff/4` was receiving the `RunStepError` wrapper instead of the inner error. This was inconsistent with all other code paths, where `backoff/4` receives the unwrapped error.
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compensate/4returns bare:retry,backoff/4was receiving theRunStepErrorwrapper instead of the inner error. All other code paths pass the unwrapped error, so this was inconsistent and meant pattern matching on the error inbackoff/4wouldn't work as expected.backoff/4receives the unwrapped error.Closes #300, closes #301
Test plan
mix check --no-retrypasses all 13 checks