Skip to content

fix: pass unwrapped error to backoff/4 on bare :retry from compensate/4 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimsynz merged 1 commit into from
Apr 6, 2026
Merged

fix: pass unwrapped error to backoff/4 on bare :retry from compensate/4 #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/reactor/executor/step_runner.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ defmodule Reactor.Executor.StepRunner do
defp handle_compensate_result(:retry, reactor, step, arguments, context, reason) do
Hooks.event(reactor, :compensate_retry, step, context)

case Step.backoff(step, reason, arguments, context) do
case Step.backoff(step, reason.error, arguments, context) do
delay when is_integer(delay) and delay > 0 -> {:backoff, delay, {:retry, reason}}
_ -> {:retry, reason}
end
Expand Down
2 changes: 1 addition & 1 deletion test/reactor/executor/step_runner_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ defmodule Reactor.Executor.StepRunnerTest do
Example.Step.Compensable
|> stub(:run, fn _, _, _ -> {:error, :doc} end)
|> stub(:compensate, fn :doc, _, _, _ -> :retry end)
|> stub(:backoff, fn _, _, _, _ -> 100 end)
|> stub(:backoff, fn :doc, _, _, _ -> 100 end)

assert {:backoff, 100, {:retry, %RunStepError{error: :doc}}} =
run(reactor, state, step, nil)
Expand Down
Loading