Rework the client package #35
Merged
matt-mazzucato merged 7 commits intoastarte-platform:masterfrom Feb 14, 2023
Merged
Conversation
In the context of astarte-platform#33, bump Go in order to use newer features of the language. Update the CI workflows. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
revamp-client
branch
5 times, most recently
from
572a56e to
3b7686a
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
===========================================
+ Coverage 34.92% 49.54% +14.62%
===========================================
Files 13 20 +7
Lines 982 1441 +459
===========================================
+ Hits 343 714 +371
- Misses 600 638 +38
- Partials 39 89 +50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
As stated in astarte-platform#33, currently the client package has a number of issues. For start, provide a new, state-of-the-art, client API (using functional options). Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
revamp-client
branch
from
3b7686a to
6283049
Compare
matt-mazzucato
requested changes
Feb 8, 2023
Collaborator
matt-mazzucato
left a comment
matt-mazzucato
left a comment
There was a problem hiding this comment.
Besides the required small changes, I think it would be beneficial adding (within the README) minimal guidelines about the advised development paths.
Annopaolo
force-pushed
the
revamp-client
branch
from
6283049 to
6ee2083
Compare
matt-mazzucato
approved these changes
Feb 9, 2023
rbino
suggested changes
Feb 9, 2023
In the context of astarte-platform#33, rationalize and update the current API for interacting with Astarte Pairing. Use a type-safe request/response pattern. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
In the context of astarte-platform#33, rationalize and update the current API for interacting with Astarte Housekeeping. Use a type-safe request/response pattern. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
In the context of astarte-platform#33, rationalize and update the current API for interacting with Astarte Realm Management. Use a type-safe request/response pattern. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
In the context of astarte-platform#33, rationalize and update the current API for interacting with Astarte Appengine. Use a type-safe request/response pattern. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
revamp-client
branch
4 times, most recently
from
1d7ce03 to
b1e473b
Compare
Annopaolo
force-pushed
the
revamp-client
branch
from
b1e473b to
ba576d8
Compare
As the last step of resolving astarte-platform#33, replace the old client package with a new one, more idiomatic and simple. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
revamp-client
branch
from
ba576d8 to
f4f6d75
Compare
rbino
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in #30, the client package is made more clean, idiomatic and type-safe. The request/response pattern used throughout is borrowed from Go's http module.
Close #33.