Rework the client package

.github/workflows/build.yaml

@@ -16,8 +16,8 @@ jobs:
     strategy:
       matrix:
         go:
-        - 1.17.x
         - 1.18.x
+        - 1.19.x
         os:
         - ubuntu-latest
         - macos-latest
@@ -33,11 +33,11 @@ jobs:
       run: go build -v ./...
     - name: Test (with coverprofile)
       run: go test -v -race -coverprofile=coverage.txt -covermode=atomic ./...
-      if: matrix.os == 'ubuntu-latest' && matrix.go == '1.17.x'
+      if: matrix.os == 'ubuntu-latest' && matrix.go == '1.18.x'
     - name: Test (no coverprofile)
       run: go test -v -race ./...
-      if: matrix.os != 'ubuntu-latest' || matrix.go != '1.17.x'
+      if: matrix.os != 'ubuntu-latest' || matrix.go != '1.18.x'
     # Upload coverage report only in one case of the matrix
     - name: Upload coverage report
       uses: codecov/codecov-action@v1
-      if: matrix.os == 'ubuntu-latest' && matrix.go == '1.17.x'
+      if: matrix.os == 'ubuntu-latest' && matrix.go == '1.18.x'

.github/workflows/golangci-lint.yaml

@@ -28,10 +28,10 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-go@v2
       with:
-        # Ensure we're on Go 1.17
-        go-version: '1.17.x'
+        # Ensure we're on Go 1.18
+        go-version: '1.18.x'
     # Run golint-ci
     - name: Run golangci-lint
       run: |
-        curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.25.1
+        curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.51.1
         ./bin/golangci-lint run

.golangci.yml

@@ -6,7 +6,9 @@ run:
   # timeout for analysis, e.g. 30s, 5m, default is 1m
   # Allow 10m, within actions it might take a lot
   timeout: 10m
-
+  # Ignore the beautiful, beautiful Astarte mock file
+  skip-files:
+    - client/astarte_mock.go
 # output configuration options
 output:
   # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
@@ -116,6 +118,7 @@ linters-settings:
     allow-separated-leading-comment: false
 
 linters:
+  disable-all: true
   enable:
     - bodyclose
     - dupl
@@ -125,16 +128,16 @@ linters:
     - goconst
     - gocritic
     - gocyclo
-    - golint
+    - revive
     - gofmt
     - goimports
     - goprintffuncname
     - gosec
     #- lll
-    - maligned
+    # - fieldalignment # TODO: Disabled temporairly, enable it back when memory aligning fields
     - misspell
     - prealloc
-    - scopelint
+    - exportloopref
     - unconvert
     - unparam
 
@@ -170,7 +173,14 @@ issues:
     - linters:
         - gocyclo
         - funlen
+        - gocognit
       source: "^func validateType"
+
+    - linters:
+        - gocyclo
+        - funlen
+        - gocognit
+      source: "^func validate"
 
     # We might have some unused boilerplate functions
     - linters:

.tool-versions

@@ -1 +1 @@
-golang 1.17.8
+golang 1.18.8

CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [Unreleased]
 ### Changed
 - Replace device `metadata` with `attributes`.
+- BREAKING: Remove the 0.90.1 Astarte client API and introduce a clean, idiomatic API.
+  See [#33](https://github.com/astarte-platform/astarte-go/issues/33).
 
 ## [0.90.1] - 2021-03-03
 ### Changed