refactor(appengine): use changesets in merge_device_status#1057
Merged
Annopaolo merged 1 commit intoastarte-platform:release-1.2from Mar 17, 2025
Merged
refactor(appengine): use changesets in merge_device_status#1057Annopaolo merged 1 commit intoastarte-platform:release-1.2from
Annopaolo merged 1 commit intoastarte-platform:release-1.2from
Conversation
2597d1f to
ae45db0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1057 +/- ##
===============================================
- Coverage 70.73% 68.52% -2.22%
===============================================
Files 176 329 +153
Lines 5184 7593 +2409
===============================================
+ Hits 3667 5203 +1536
- Misses 1517 2390 +873 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4eb210e to
4bf028a
Compare
5367a9e to
9c481b5
Compare
9c481b5 to
03eedff
Compare
03eedff to
a9f283f
Compare
a9f283f to
25fc523
Compare
5 tasks
rewrite merge_device_status to use changesets to minimize the number of queries performed. refactor some private functions in their own modules. Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
25fc523 to
8161478
Compare
Annopaolo
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite merge_device_status to use changesets to minimize the number
of queries performed.
refactor some private functions in their own modules.
depends on #1056depends on #1128What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: