Skip to content

refactor(appengine): use changesets in merge_device_status#1057

Merged
Annopaolo merged 1 commit intoastarte-platform:release-1.2from
noaccOS:push-qktnrvyknxsm
Mar 17, 2025
Merged

refactor(appengine): use changesets in merge_device_status#1057
Annopaolo merged 1 commit intoastarte-platform:release-1.2from
noaccOS:push-qktnrvyknxsm

Conversation

@noaccOS
Copy link
Copy Markdown
Collaborator

@noaccOS noaccOS commented Jan 22, 2025

rewrite merge_device_status to use changesets to minimize the number
of queries performed.

refactor some private functions in their own modules.

depends on #1056
depends on #1128

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?
  • Yes
  • No

Additional documentation e.g. usage docs, diagrams, etc.:


@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.52%. Comparing base (0e0452e) to head (8161478).
Report is 28 commits behind head on release-1.2.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2    #1057      +/-   ##
===============================================
- Coverage        70.73%   68.52%   -2.22%     
===============================================
  Files              176      329     +153     
  Lines             5184     7593    +2409     
===============================================
+ Hits              3667     5203    +1536     
- Misses            1517     2390     +873     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noaccOS noaccOS force-pushed the push-qktnrvyknxsm branch 9 times, most recently from 4eb210e to 4bf028a Compare January 29, 2025 16:57
@noaccOS noaccOS force-pushed the push-qktnrvyknxsm branch 5 times, most recently from 5367a9e to 9c481b5 Compare February 3, 2025 16:51
@noaccOS noaccOS force-pushed the push-qktnrvyknxsm branch from 03eedff to a9f283f Compare March 7, 2025 13:42
@noaccOS noaccOS changed the base branch from master to release-1.2 March 7, 2025 13:42
@noaccOS noaccOS force-pushed the push-qktnrvyknxsm branch from a9f283f to 25fc523 Compare March 7, 2025 13:43
@noaccOS noaccOS changed the title refactor(appengine): merge_device_status refactor(appengine): use changesets in merge_device_status Mar 7, 2025
rewrite merge_device_status to use changesets to minimize the number
of queries performed.

refactor some private functions in their own modules.

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS noaccOS force-pushed the push-qktnrvyknxsm branch from 25fc523 to 8161478 Compare March 11, 2025 10:55
@Annopaolo Annopaolo merged commit 80a3450 into astarte-platform:release-1.2 Mar 17, 2025
29 checks passed
@noaccOS noaccOS deleted the push-qktnrvyknxsm branch March 17, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants