refactor(device): preparations for merge_device_status#1128
Merged
Annopaolo merged 2 commits intoastarte-platform:release-1.2from Mar 11, 2025
Merged
Conversation
split the retrieve_device_status functions into two, so that it can also return the device itself, which can be later used to generate the status Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
the changes in b27c5a4 made some calls return the device status where the timestmaps have nanosecond precision. this commit restores the behvavior before this commit, truncating the timestamps to millisecond Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1128 +/- ##
===============================================
- Coverage 68.76% 68.76% -0.01%
===============================================
Files 327 327
Lines 7504 7513 +9
===============================================
+ Hits 5160 5166 +6
- Misses 2344 2347 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
lusergit
approved these changes
Mar 7, 2025
Annopaolo
approved these changes
Mar 11, 2025
ef92d76
into
astarte-platform:release-1.2
55 of 56 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation commits for #1057.
DeviceStatus.from_db_rowtrim the timestamps to millisecond precision, like the version in the Queries module. This also restores a test from before the refactors done lately.What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: