download-metadata: Use ndjson instead of GH releases for CPython#18406
Open
download-metadata: Use ndjson instead of GH releases for CPython#18406
Conversation
zsol
changed the title
zsol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to use our releases mirror and not fail when github flakes out. It also is 10x faster than before (no need to go through github's pagination).
Note: I haven't implemented fallback to raw.githubusercontent.com, because this script is only run on CI.
Test plan
regenerate the json and check the diff:
https://gist.github.com/zsol/cce4447fb6fa30c7bf7e6de7246298be
This shows a bunch of releases (before 20211017) completely missing - likely due to omission from the ndjson