Skip to content

fix: ticket section render issue using slider component#478

Closed
toffee-k21 wants to merge 0 commit intoasyncapi:masterfrom
toffee-k21:add/feat-add-render
Closed

fix: ticket section render issue using slider component#478
toffee-k21 wants to merge 0 commit intoasyncapi:masterfrom
toffee-k21:add/feat-add-render

Conversation

@toffee-k21
Copy link
Contributor

Description

fixes #395
fixed card rendering issue in the Ticket section

@netlify
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 27c9f3e
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6764413b666c580008706737
😎 Deploy Preview https://deploy-preview-478--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@toffee-k21 the tickets are breaking in the on compressed view.

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a test in the cypress test suite, for the changes you have made.

@toffee-k21
Copy link
Contributor Author

Also add a test in the cypress test suite, for the changes you have made.

Hey @ashmit-coder, I have made the changes you suggested and also added Cypress tests for the changes I made.

Additionally, there was an issue with the overflow of the slider component, which I have fixed. Below is the video regarding that

ScreenRec_2024-11-28.18-03-55.mp4
ScreenRec_2024-11-28.19-12-48.mp4

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @toffee-k21, few suggested changes

  • I noticed the venues on the landing is aligned to the left on desktop view
  • I think you should remove the description in the ticket card and just keep it simple

@toffee-k21
Copy link
Contributor Author

Thanks @AceTheCreator for your feedback, I have implemented what you suggested. Let me know if there's anything else you'd like me to adjust!

@ashmit-coder
Copy link
Contributor

Thanks @AceTheCreator for your feedback, I have implemented what you suggested. Let me know if there's anything else you'd like me to adjust!

cc: @AceTheCreator

@AceTheCreator
Copy link
Member

@toffee-k21, sorry for the late response. Can you resolve the conflict in this PR

@toffee-k21
Copy link
Contributor Author

toffee-k21 commented Jan 29, 2025

@AceTheCreator, I had to create a new PR #547 due to sync issues. Let me know if everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the way the ticket section is being rendered

3 participants