Skip to content

fix: layout glitches when toggling navigation or editor panels #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ishita-190 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: layout glitches when toggling navigation or editor panels #1283

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55415bb
fix layout glitches
Ishita-190 Feb 15, 2026
fe81e05
Merge branch 'master' into ishi
asyncapi-bot Feb 15, 2026
860b6dd
addded missing display name
Ishita-190 Feb 15, 2026
51c1c37
add missing component name
Ishita-190 Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 108 additions & 36 deletions apps/studio/src/components/Content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ import { VisualiserTemplate } from './Visualiser';
import { debounce } from '@/helpers';
import { usePanelsState, useDocumentsState } from '@/state';

import { FunctionComponent } from 'react';
import React, { FunctionComponent, useMemo, useCallback } from 'react';

interface ContentProps {}

export const Content: FunctionComponent<ContentProps> = () => { // eslint-disable-line sonarjs/cognitive-complexity
const ContentComponent: FunctionComponent<ContentProps> = () => {
const { show, secondaryPanelType } = usePanelsState();
const document = useDocumentsState(state => state.documents['asyncapi']?.document) || null;
const document =
useDocumentsState(state => state.documents['asyncapi']?.document) || null;

const isV3 = document?.version() === '3.0.0';
const navigationEnabled = show.primarySidebar;
const editorEnabled = show.primaryPanel;
Expand All @@ -24,29 +26,101 @@ export const Content: FunctionComponent<ContentProps> = () => { // eslint-disabl
const splitPosLeft = 'splitPos:left';
const splitPosRight = 'splitPos:right';

const localStorageLeftPaneSize = parseInt(localStorage.getItem(splitPosLeft) || '0', 10) || 220;
const localStorageRightPaneSize = parseInt(localStorage.getItem(splitPosRight) || '0', 10) || '55%';

const secondPaneSize = navigationEnabled && !editorEnabled ? localStorageLeftPaneSize : localStorageRightPaneSize;
const secondPaneMaxSize = navigationEnabled && !editorEnabled ? 360 : '100%';

const navigationAndEditor = (
<SplitPane
minSize={220}
maxSize={360}
pane1Style={navigationEnabled ? { overflow: 'auto' } : { width: '0px' }}
pane2Style={editorEnabled ? undefined : { width: '0px' }}
primary={editorEnabled ? 'first' : 'second'}
defaultSize={localStorageLeftPaneSize}
onChange={debounce((size: string) => {
localStorage.setItem(splitPosLeft, String(size));
}, 100)}
>
{
isV3 ? <Navigationv3 /> : <Navigation />
}
<Editor />
</SplitPane>
const localStorageLeftPaneSize = useMemo(
() => parseInt(localStorage.getItem(splitPosLeft) || '0', 10) || 220,
[splitPosLeft]
);

const localStorageRightPaneSize = useMemo(
() => parseInt(localStorage.getItem(splitPosRight) || '0', 10) || '55%',
[splitPosRight]
);

const secondPaneSize = useMemo(() => {
if (!navigationEnabled && !editorEnabled) {
return 0;
}
return navigationEnabled && !editorEnabled
? localStorageLeftPaneSize
: localStorageRightPaneSize;
}, [
navigationEnabled,
editorEnabled,
localStorageLeftPaneSize,
localStorageRightPaneSize,
]);

const secondPaneMaxSize = useMemo(
() => (navigationEnabled && !editorEnabled ? 360 : '100%'),
[navigationEnabled, editorEnabled]
);

const handleLeftPaneResize = useCallback(
(size: string) => {
localStorage.setItem(splitPosLeft, String(size));
},
[splitPosLeft]
);

const handleRightPaneResize = useCallback(
(size: string) => {
localStorage.setItem(splitPosRight, String(size));
},
[splitPosRight]
);

const debouncedLeftResize = useMemo(
() => debounce(handleLeftPaneResize, 100),
[handleLeftPaneResize]
);

const debouncedRightResize = useMemo(
() => debounce(handleRightPaneResize, 100),
[handleRightPaneResize]
);

const navigationAndEditor = useMemo(
() => (
<SplitPane
minSize={220}
maxSize={360}
pane1Style={
navigationEnabled ? { overflow: 'auto' } : { width: '0px' }
}
pane2Style={
editorEnabled ? undefined : { width: '0px' }
}
primary="first"
defaultSize={localStorageLeftPaneSize}
onChange={debouncedLeftResize}
>
{isV3 ? <Navigationv3 /> : <Navigation />}
<Editor />
</SplitPane>
),
[
navigationEnabled,
editorEnabled,
localStorageLeftPaneSize,
isV3,
debouncedLeftResize,
]
);

const leftPaneStyle = useMemo(
() =>
navigationEnabled || editorEnabled
? undefined
: { width: '0px' },
[navigationEnabled, editorEnabled]
);

const rightPaneStyle = useMemo(
() =>
viewEnabled
? { overflow: 'auto' }
: { width: '0px' },
[viewEnabled]
);

return (
Expand All @@ -56,23 +130,21 @@ export const Content: FunctionComponent<ContentProps> = () => { // eslint-disabl
size={viewEnabled ? secondPaneSize : 0}
minSize={0}
maxSize={secondPaneMaxSize}
pane1Style={
navigationEnabled || editorEnabled ? undefined : { width: '0px' }
}
pane2Style={
viewEnabled ? { overflow: 'auto' } : { width: '0px' }
}
pane1Style={leftPaneStyle}
pane2Style={rightPaneStyle}
primary={viewEnabled ? 'first' : 'second'}
defaultSize={localStorageRightPaneSize}
onChange={debounce((size: string) => {
localStorage.setItem(splitPosRight, String(size));
}, 100)}
onChange={debouncedRightResize}
>
{navigationAndEditor}
{viewType === 'template' && <Template />}
{viewType === 'visualiser' && <VisualiserTemplate />}
</SplitPane>
</SplitPane>
</div>
</div>
);
};

ContentComponent.displayName = 'Content';

export const Content = React.memo(ContentComponent);