Skip to content

Admit nested named logical writes - #2976

Merged
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-19
Jun 1, 2026
Merged

Admit nested named logical writes#2976
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-19

Conversation

@rogeralsing

Copy link
Copy Markdown
Contributor

Summary

  • admit nested named receiver logical writes like box.child.value &&= value into production unified bytecode
  • make the named logical property-set selector/compiler prefix-aware while preserving private/optional receiver declines and short-circuit cleanup
  • update the unified bytecode expansion contract and add eligibility/runtime proofs

Verification

  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_NestedNamedLogicalAssignment_AcceptsWithOwnedOpcodes|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_LogicalAndAssignment_UnsupportedShapes_DeclineWithExplicitCodes|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.NestedNamedLogicalPropertyWrite_UsesUnifiedBytecodeProductionFastPathAndShortCircuits|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.ComputedLogicalPropertyWrite_AssignmentBranchPreservesResultAndSetterSemantics"
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests|FullyQualifiedNameExpressionProgramCoverageMapTests.UnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums|FullyQualifiedName~UnifiedBytecodeProductionInvocationTests"
  • rtk dotnet build src/Asynkron.JsEngine/Asynkron.JsEngine.csproj -c Release
  • rtk git diff --check
  • rtk rg "EvaluateExpression(|ProfileEvaluateExpression(" src/Asynkron.JsEngine/Ast/TypedAstEvaluator.ExecutionPlanRunner*
  • rtk ./tools/profile forloop --memory

Notes

  • Focused proof passed with the existing unrelated nullable warnings in debug tests; the wider production pack and Release build had 0 warnings.

Copilot AI review requested due to automatic review settings June 1, 2026 12:29
@rogeralsing
rogeralsing merged commit 02341fd into main Jun 1, 2026
@rogeralsing
rogeralsing deleted the codex/unified-bytecode-loop-19 branch June 1, 2026 12:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants