-
Notifications
You must be signed in to change notification settings - Fork 23
Added checkboxes for file reviewing #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bec4a3d
to
1066d7c
Compare
|
||
export abstract class BitbucketExplorer extends Explorer implements Disposable { | ||
private _disposable: Disposable; | ||
|
||
private monitor: BitbucketActivityMonitor | undefined; | ||
private _refreshTimer: RefreshTimer; | ||
private _onDidChangeTreeData = new vscode.EventEmitter<AbstractBaseNode | undefined>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to pr explorer section
|
||
constructor(protected ctx: BitbucketContext) { | ||
super(() => this.dispose()); | ||
|
||
setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why>
const directoryNodes: DirectoryNode[] = Array.from( | ||
rootDirectory.subdirs.values(), | ||
(subdir) => new DirectoryNode(subdir), | ||
(subdir) => new DirectoryNode(subdir, section, pr, commitRange?.rhs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr needed?
item.checkboxState = this.checked | ||
? vscode.TreeItemCheckboxState.Checked | ||
: vscode.TreeItemCheckboxState.Unchecked; | ||
item.contextValue = `directory${allChecked ? '.checked' : ''}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
What Is This Change?
In this PR,
Basic checks:
npm run lint
npm run test
Advanced checks:
Recommendations: