Skip to content

Added checkboxes for file reviewing #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sn2912
Copy link
Contributor

@sn2912 sn2912 commented Apr 15, 2025

What Is This Change?

In this PR,

  • Moved files to a new section called Files
  • Added checkboxes to review files in both commit section and files section
  • Checkboxes maintain state based on latest file content
  • Checkboxes maintain different states across different commits and sections
  • Basic checks:

    • npm run lint
    • npm run test

    Advanced checks:

    • If Atlassian employee & Bitbucket changes: did you test with DC in mind? See Instructions

    Recommendations:

    • Update the CHANGELOG if making a user facing change

@sn2912 sn2912 force-pushed the add-checkbox-content-based-hashing branch from bec4a3d to 1066d7c Compare April 15, 2025 05:12

export abstract class BitbucketExplorer extends Explorer implements Disposable {
private _disposable: Disposable;

private monitor: BitbucketActivityMonitor | undefined;
private _refreshTimer: RefreshTimer;
private _onDidChangeTreeData = new vscode.EventEmitter<AbstractBaseNode | undefined>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to pr explorer section


constructor(protected ctx: BitbucketContext) {
super(() => this.dispose());

setTimeout(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why>

const directoryNodes: DirectoryNode[] = Array.from(
rootDirectory.subdirs.values(),
(subdir) => new DirectoryNode(subdir),
(subdir) => new DirectoryNode(subdir, section, pr, commitRange?.rhs),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr needed?

item.checkboxState = this.checked
? vscode.TreeItemCheckboxState.Checked
: vscode.TreeItemCheckboxState.Unchecked;
item.contextValue = `directory${allChecked ? '.checked' : ''}`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant