Skip to content

Conversation

@elijahladdie
Copy link
Contributor

@elijahladdie elijahladdie commented Oct 14, 2024

fix: can't read undefined of organization while creating new organization

PR Description

Please include a brief description of the pull request you want to raise.

Description of tasks that were expected to be completed

  • I added ? before organization in team resolver while getting teams

Functionality

  • navigate to create team menu. and you won't find any warning or error toast message that tasks about it.

How has this been tested?

i created new team to make sure that before I select new

PR Checklist:

  • ? is added to make sure application won't crash if the organization is not available

@elijahladdie elijahladdie changed the title fix: can't read undefinded of origanization while creating new organi… fix: can't read undefineded of organization while creating new organization Oct 14, 2024
@elijahladdie elijahladdie changed the title fix: can't read undefineded of organization while creating new organization fix: can't read undefined of organization while creating new organization Oct 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@27f9fb6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/team.resolvers.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #359   +/-   ##
==========================================
  Coverage           ?   16.57%           
==========================================
  Files              ?       96           
  Lines              ?     3782           
  Branches           ?     1075           
==========================================
  Hits               ?      627           
  Misses             ?     3144           
  Partials           ?       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

const org = await checkLoggedInOrganization(orgToken)

if (cohortOrg.id.toString() !== org.id.toString()) {
console.log('>>>>>>>>>>>>>')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijahladdie remove these console.logs

req && req.headers.authorization
? decodeAuthHeader(req.headers.authorization)
: null
if (
Copy link
Member

@aimedivin aimedivin Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijahladdie , also look into this

@ceelogre ceelogre temporarily deployed to fix-create-team-bug - devpulse-backend PR #359 November 19, 2024 10:21 — with Render Destroyed
@elijahladdie
Copy link
Contributor Author

Solved in other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants