Skip to content

fix: can't read undefined of organization while creating new organization #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: can't read undefined of organization while creating new organization #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ export const context = async ({ req }: { req: Request }): Promise<Context> => {
if (
Copy link
Member

@aimedivin aimedivin Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijahladdie , also look into this

!token &&
!req.body.variables.organisationInput &&
!req.body.variables.loginInput
!req.body.variables.organizationInput &&
!req.body.variables.loginInput &&
!req.body.variables.orgToken &&
!req.body.variables.orgInput
) {
return { clientIpAdress }
} else {
Expand Down
8 changes: 5 additions & 3 deletions src/resolvers/team.resolvers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ const resolvers = {
const prevTeamName = team.name
const teamCohort = team?.cohort
const cohortProgram = team?.cohort?.program as ProgramType
const cohortOrg = cohortProgram.organization as OrganizationType
const cohortOrg = cohortProgram?.organization as OrganizationType
const org = await checkLoggedInOrganization(orgToken)

if (!team) {
Expand All @@ -564,8 +564,10 @@ const resolvers = {

if (role !== RoleOfUser.SUPER_ADMIN) {
const org = await checkLoggedInOrganization(orgToken)

if (cohortOrg.id.toString() !== org.id.toString()) {
console.log('>>>>>>>>>>>>>')
Copy link
Member

@aimedivin aimedivin Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijahladdie remove these console.logs

console.log(cohortOrg)
console.log('>>>>>>>>>>>>>')
if (cohortOrg?.id.toString() !== org.id.toString()) {
throw new GraphQLError(
`Team with id "${team?.id}" doesn't exist in this organization`,
{
Expand Down
Loading