fix: replace package-template with feopack in native binding loader#1
Open
CoderSerio wants to merge 9 commits intomainfrom
Open
fix: replace package-template with feopack in native binding loader#1CoderSerio wants to merge 9 commits intomainfrom
CoderSerio wants to merge 9 commits intomainfrom
Conversation
- Update index.js to use correct binary name 'feopack' instead of template placeholder - Fix repository URL in package.json to point to atom-universe/FeOPack This fixes the native binding loading issue where the generated index.js was still referencing the napi-rs package-template instead of feopack.
CoderSerio
force-pushed
the
fix/native-binding-name
branch
2 times, most recently
from
cd49b8a to
0bb9f12
Compare
added 8 commits
March 6, 2026 15:29
- CI workflow calls 'yarn build' which didn't exist - Added: napi build --platform --release
- Remove @feopack/cli workspace dependency (doesn't exist) - Add build script: napi build --platform --release
- Removed non-existent @feopack/cli workspace dependency - Added missing 'build' script for CI - Regenerated yarn.lock to match package.json
- Build script needs --package node-binding for cargo workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
index.js（napi-rs 生成的原生绑定加载器）仍引用模板占位符package-template，而非项目名feopack。修复
index.js: 替换 78 处package-template→feopackpackage.json: 修正仓库 URL →atom-universe/FeOPack影响
修复后，原生绑定加载器能正确加载 feopack 二进制文件。
注意
这是从 napi-rs package-template fork 后的必要修复。理想情况下应通过
napi build --platform重新生成index.js。