fix(ci): use SVG logo in OLM bundle and generate icon at build time#132
Merged
Conversation
SebTardif
added a commit
that referenced
this pull request
May 29, 2026
The 'Wait for lint and unit gate' step polls the GitHub API to check job status before running E2E tests. If the API returns truncated JSON, jq parse fails and set -Eeuo pipefail kills the step immediately. Add retry-on-failure: validate the API response with jq empty before parsing, and continue the poll loop on transient failures instead of aborting the entire E2E job. Fixes a flaky E2E failure seen on PR #132 (run 26617885011). Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
force-pushed
the
ci/olm-svg-icon
branch
3 times, most recently
from
bb67a78 to
e280e34
Compare
Replace hardcoded PNG base64 (19 KB) with SVG (1.7 KB) read from docs/logo.svg at bundle generation time. The icon now stays in sync with any logo updates automatically. Substitution points: __VERSION__, __DATE__, __ICON_BASE64__. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
force-pushed
the
ci/olm-svg-icon
branch
from
e280e34 to
3352246
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded PNG base64 (19 KB) with SVG (1.7 KB) read from
docs/logo.svgat bundle generation time. The icon now stays in sync with any logo updates automatically.Before: Icon was baked into the CSV template as a 19 KB PNG base64 string. Logo changes required manually re-encoding and updating the template.
After:
make generate-olm-bundlereadsdocs/logo.svg, base64-encodes it, and substitutes the__ICON_BASE64__placeholder. 225x smaller, always current.