fix: scope workflow token permissions to job level for Scorecard#42
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…te cache key hashing - Pin mkdocs-material==9.7.6 in docs.yaml and ci.yaml (Scorecard Pinned-Dependencies alert #1) - Move pages/id-token write permissions to deploy job in docs.yaml - Add nolint annotations on SHA256 cache key derivation (not password storage); CodeQL alerts #10 and #11 dismissed as false positives Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
force-pushed
the
fix/scorecard-token-permissions
branch
from
be9c8cf to
435f8fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves write permissions from workflow-level to job-level in 4 workflows
to satisfy OpenSSF Scorecard Token-Permissions checks.
What changed
backport.yamlcontents: write,pull-requests: writecontents: read/ write atbackportjobdependabot-auto-merge.yamlcontents: write,pull-requests: writecontents: read/ write atauto-mergejobsecurity.yamlsecurity-events: writecontents: read/ write atcodeqljob onlyrelease.yamlcontents: write,packages: write,id-token: writecontents: read/ write atreleaseandhelm-releasejobsThe
provenanceandcontainer-provenancejobs inrelease.yamlalreadyhad job-level permissions and are unchanged.
Why
Scorecard Token-Permissions penalizes workflows with top-level write
permissions because a compromised or malicious step in any job inherits
those permissions. Job-level scoping ensures each job gets only the
access it actually needs.
Resolves Scorecard alerts #2, #3, #4, #5, #12.