Skip to content

fix: make configuration validation not throw #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Apr 3, 2025

fixes #2033

Changes:

Configuration validation step now does not throw an error in the case of a missing property. Instead, a warning message is logged (with the same content as the error message being thrown earlier).

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner April 3, 2025 19:05
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (82f8246) to head (c30c387).

Files with missing lines Patch % Lines
src/server/client.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2034      +/-   ##
==========================================
- Coverage   79.70%   78.47%   -1.24%     
==========================================
  Files          21       21              
  Lines        1927     1909      -18     
  Branches      320      307      -13     
==========================================
- Hits         1536     1498      -38     
- Misses        385      405      +20     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jesseflikweerteo
Copy link

Hey @tusharpandey13, do you have an estimated release timeline for this? Based on the interest in the popular #2033, it looks like quite a few people are eagerly waiting on it.

@frederikprijck frederikprijck enabled auto-merge (squash) April 10, 2025 09:10
@frederikprijck frederikprijck merged commit dbfd502 into main Apr 10, 2025
12 checks passed
@frederikprijck frederikprijck deleted the feature/configuration-validation branch April 10, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.4.1: ConfigurationError thrown in pipeline as variables are not available on build time
6 participants