Skip to content

Commit d48e338

Browse files
committed
fix doc comments and fix to move
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
1 parent 7f3abd6 commit d48e338

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

  • common/autoware_agnocast_wrapper

common/autoware_agnocast_wrapper/include/autoware/agnocast_wrapper/node.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ class Node
420420
}
421421
};
422422

423-
/// @brief Get the underlying rclcpp::Node from a node that inherits agnocast_wrapper::Node.
423+
/// @brief Get the underlying rclcpp::Node from an agnocast_wrapper::Node.
424424
/// @throws std::runtime_error if the node is in agnocast mode (check !use_agnocast() first)
425425
template <typename T>
426426
std::shared_ptr<rclcpp::Node> to_rclcpp_node(const std::shared_ptr<T> & node)
@@ -588,7 +588,7 @@ class Node
588588
rclcpp::node_interfaces::OnSetParametersCallbackHandle::SharedPtr add_on_set_parameters_callback(
589589
OnSetParametersCallbackType callback)
590590
{
591-
return node_->add_on_set_parameters_callback(callback);
591+
return node_->add_on_set_parameters_callback(std::move(callback));
592592
}
593593
void remove_on_set_parameters_callback(
594594
const rclcpp::node_interfaces::OnSetParametersCallbackHandle * const handler)
@@ -745,7 +745,7 @@ class Node
745745
std::shared_ptr<rclcpp::Node> node_;
746746
};
747747

748-
/// @brief Get the underlying rclcpp::Node from a node that inherits agnocast_wrapper::Node.
748+
/// @brief Get the underlying rclcpp::Node from an agnocast_wrapper::Node.
749749
template <typename T>
750750
std::shared_ptr<rclcpp::Node> to_rclcpp_node(const std::shared_ptr<T> & node)
751751
{

common/autoware_agnocast_wrapper/src/node.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ rcl_interfaces::msg::ListParametersResult Node::list_parameters(
182182
rclcpp::node_interfaces::OnSetParametersCallbackHandle::SharedPtr
183183
Node::add_on_set_parameters_callback(OnSetParametersCallbackType callback)
184184
{
185-
return visit_node([&](auto & n) { return n->add_on_set_parameters_callback(callback); });
185+
return visit_node([&](auto & n) { return n->add_on_set_parameters_callback(std::move(callback)); });
186186
}
187187

188188
void Node::remove_on_set_parameters_callback(

0 commit comments

Comments
 (0)