Skip to content

Commit 98259e3

Browse files
committed
fix(planning_data_analyzer): address review comments
1 parent 856d6bf commit 98259e3

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

planning/autoware_planning_data_analyzer/src/bag_handler.hpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,10 @@ struct BagData
9797
}
9898
create_buffer<PredictedObjects>(
9999
topic_names.objects_topic, buffer_duration_sec, max_buffer_msgs);
100-
create_buffer<TrafficLightGroupArray>(
101-
topic_names.traffic_signals_topic, buffer_duration_sec, max_buffer_msgs);
100+
if (!topic_names.traffic_signals_topic.empty()) {
101+
create_buffer<TrafficLightGroupArray>(
102+
topic_names.traffic_signals_topic, buffer_duration_sec, max_buffer_msgs);
103+
}
102104
create_buffer<SteeringReport>(topic_names.steering_topic, buffer_duration_sec, max_buffer_msgs);
103105
}
104106

planning/autoware_planning_data_analyzer/src/buffer.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
#include <cmath>
2424
#include <limits>
2525
#include <memory>
26+
#include <type_traits>
27+
#include <utility>
2628
#include <vector>
2729

2830
namespace autoware::planning_data_analyzer

planning/autoware_planning_data_analyzer/src/metrics/ttc_within_bound.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
#include <limits>
2929
#include <optional>
3030
#include <string>
31+
#include <tf2/LinearMath/Vector3.hpp>
32+
#include <tf2/utils.h>
3133
#include <unordered_set>
3234

3335
namespace autoware::planning_data_analyzer::metrics

0 commit comments

Comments
 (0)